-
Notifications
You must be signed in to change notification settings - Fork 619
feat(instrumentation-langchain): Add LangChain.js instrumentation #2995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ackage with implementation and tests. Current WIP as tests do not have adequate code coverage
…se-please-config.json to match the suggestion given by rp-validate
…non-usage of variable in span name creation, also added extra test file, and fixed issues with existing tests (testing now covers ~80%)
|
Took a quick look and this PR is quite large. Is there any way we could decompose this into smaller pieces? For example, a PR for basic package skeleton setup and subsequent PRs focused on a particular part of the new Agentic AI semantic convention? |
|
@yiyuan-he @haneric00 I can see you both listed as component owners of this instrumentation, we do have 2 PRs trying to add the instrumentation, happy to review, but which PR we want to start with? #3132 or this one? |
Hi Hector, please start with the later PR, sorry for the confusion! |
Is it correct that this PR is superseded by #3132 ? If so can this be closed then? |
Thanks @JamieDanielson, you're correct and we can close out this PR. |
|
Closing in favor of #3132 |
Which problem is this PR solving?
Short description of the changes